Re: StringNg review request: SBuf.h

On 09/21/2010 10:00 PM, Amos Jeffries wrote:
>> I am guessing we do not care about overlapping regions in this specific
>> method because copying from SBufs to SBuf is only possible if the two
>> have different MemBlobs. The implementation should document this
>> assumption or even assert it.
>
> side tracked? above says you are discussing "Copy SBuf contents into
> user-supplied C buffer".

This is relevant. The user-supplied buffer can be SBuf::buf() or
similar. So Amos found another fix: We should remove "C" from "C buffer"
in copy() description as misleading.

Thank you,

Alex.
Received on Wed Sep 22 2010 - 04:20:03 MDT