hudsons hidden build errors

There are some build problems which are not being highlighted by the
hudson testing. Picking on FreeBSD-6.4 build because of problem #2.

1)
--enable-default-hostsfile with no arguments fails to abort:

"
configure: WARNING: Unable to find file yes. I hope you know what you
are doing.
configure: Default hosts file set to: yes
"

Due to the slash in "test \! -f " from rev10760.

Kinkie: do you recall why that slash was there?

2)
FreeBSD is passing hudson tests due to $? being 0 even if the test has
not actually been completely successful:

"

libtool: compile: g++ -DHAVE_CONFIG_H -I../../.. -I../../../include
-I../../../lib -I../../../src -I../../include -I/usr/local/include
-I/usr/include -I/usr/include -I/usr/local/include -I/usr/include
-I/usr/include -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror
-pipe -D_REENTRANT -D_FILE_OFFSET_BITS=64 -g -O2 -MT gadgets.lo -MD -MP
-MF .deps/gadgets.Tpo -c ../../../src/ssl/gadgets.cc -fPIC -DPIC -o
.libs/gadgets.o
../../../src/ssl/gadgets.cc: In function `bool
addCnToRequest(Ssl::X509_REQ_Pointer&, const char*)':
../../../src/ssl/gadgets.cc:17: warning: deprecated conversion from
string constant to `char*'
*** Error code 1
mv -f .deps/context_storage.Tpo .deps/context_storage.Plo
1 error
*** Error code 1
1 error
*** Error code 2
1 error
*** Error code 1
1 error
{ test ! -d squid-3.HEAD-BZR || { find squid-3.HEAD-BZR -type d ! -perm
-200 -exec chmod u+w {} ';' && rm -fr squid-3.HEAD-BZR; }; }
==================================================
squid-3.HEAD-BZR archives ready for distribution:
squid-3.HEAD-BZR.tar.gz
squid-3.HEAD-BZR.tar.bz2
==================================================
buildtest.sh result is 0
BUILD: .././test-suite/buildtests/layer-02-maximus.opts
*** Error code 1
*** Error code 1
*** Error code 2
*** Error code 1
Build OK. Global result is 0.
"

The execution of those test line appears to overwrite the $? magic
depended on by buildtest.sh.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.9
   Beta testers wanted for 3.2.0.3