Re: /bzr/squid3/trunk/ r11181: Portability fix: icc doesn't like string literal in assert checks

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Tue, 25 Jan 2011 23:02:59 +0000

On Tue, 25 Jan 2011 23:50:40 +0100, Kinkie wrote:
> On Tue, Jan 25, 2011 at 11:39 PM, Kinkie wrote:
>> On Tue, Jan 25, 2011 at 11:26 PM, Amos Jeffries wrote:
>>> On Tue, 25 Jan 2011 23:19:46 +0100, Francesco Chemolli wrote:
>>>> ------------------------------------------------------------
>>>> revno: 11181
>>>> committer: Francesco Chemolli
>>>> branch nick: trunk
>>>> timestamp: Tue 2011-01-25 23:19:46 +0100
>>>> message:
>>>>   Portability fix: icc doesn't like string literal in assert checks
>>>> modified:
>>>>   lib/MemPool.cc
>>>>   lib/MemPoolChunked.cc
>>>>   lib/MemPoolMalloc.cc
>>>
>>> This was bug 2868  http://bugs.squid-cache.org/show_bug.cgi?id=2868
>>>
>>> If its not too late can you redo this commit please with --fixes
>>> squid:2868 ?
>>> Otherwise just close the bug as fixed.
>>
>> Sure, I'll try.
>
> Ok done.
> What is the process for queueing it up for backporting?

Just a heads-up to me (like this).
Otherwise I tend to go by the reported earliest sighting version in the
bug report or if it looks important and is easy to port back.

Amos
Received on Tue Jan 25 2011 - 23:03:03 MST

This archive was generated by hypermail 2.2.0 : Wed Jan 26 2011 - 12:00:05 MST