Re: [PATCH] improve hack in src/base/TextException.h

On 19/02/11 11:25, Alex Rousskov wrote:
> On 01/31/2011 07:17 AM, Kinkie wrote:
>> TextException.h includes an hack to avoid the compiler noticing that
>> there are multiple instances of FileNameHashCached() in the compiled
>> binary.
>> Intel's icc doesn't like the way it is implemented, and instead of
>> trying to figure out how to have it stop complaining, I propose to use
>> a specific-purpose gcc construct, as done in this patch. Thoughts?
>> Votes?
>
> What does icc complain about? Kind of hard to agree to add more crap
> without seeing what the real problem that needs fixing is...
>
> Alex.

Current trunk with the patch reverted fails on ICC showing:

../../../src/base/TextException.h(66): error #42: operand types are
incompatible ("void *" and "unsigned int (*)(const char *)")
       bool use(void *ptr=(__null)) { return ptr != &FileNameHashCached;}

With a marker pointing at the != comparison.

If you have any alternative fix ideas the 3.ALPHA-patch job in hudson
works. You just have to include reversal of the rev11236 change since it
has already been committed.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.11
   Beta testers wanted for 3.2.0.5