Re: [PATCH] base-64 encoder upgrade

On 04/30/2011 09:37 AM, Amos Jeffries wrote:
> Version 3. Containing everything discussed so far except the
> optimization of base64_decode_len()

I do not see any bugs. You may want to check whether we can demand that
the decoded packet length is exactly the size of the ntlmhdr structure in

> + if (decodedLen < sizeof(ntlmhdr)) { /* decoding failure, return error */

but that is probably not a big deal either way.

Cheers,

Alex.
Received on Sun May 01 2011 - 00:50:11 MDT