Re: fix compilation with gcc 4.6

On 04/05/11 20:52, Christian wrote:
> Hi Amos,
>
> here is an updated version of the patch from Ismail.
>
> Kind Regards
> Chris

Thank you for the update. I will commit when our current QA instability
is over.

Ismail, are you the author I attribute the changes to? or is there
another down the line?

I was thinking that src/comm.cc chunk would become:
   if (TOS)
     comm_set_tos(...)

[no need for another patch, I can do that on merge to trunk]

Amos

>
> Am 02.05.2011 03:49, schrieb Amos Jeffries:
>> On Sun, 01 May 2011 20:56:20 +0200, Christian wrote:
>>> Hi,
>>>
>>> perhaps you're interested in this patch:
>>> coming originally from fedora.
>>>
>>> remove write only variables to fix compilation with gcc 4.6
>>> Kind Regards
>>
>> Thank you.
>> most of these chunks appear fine. There are several which erase whole
>> function calls though.
>>
>> src/comm.cc:
>> comm_set_tos() removal breaks QoS.
>>
>> src/dns_internal.cc:
>> comm_local_port() removal breaks DNS local port logging and retries.
>>
>> src/fqdncache.cc:
>> "++FqdncacheStats.replies" removal breaks DNS accounting.
>>
>> Amos
>>
>

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.12
   Beta testers wanted for 3.2.0.7 and 3.1.12.1