Re: [PATCH] pinning cleanup (testers wanted)

On 11/02/11 02:38, Amos Jeffries wrote:
> Since 1xx handing went in HttpRequest has had two links to the one
> ConnStateData managing its client connection.
>
> * Rename the 1xx link to clientConnectionManager (since it is not
> actually the connection, but the manager object controlling the FD usage
> and stats.
>
> * Convert the pinning code to using the permanent
> clientConnectionManager link instead of a temporary pinned_connection link.
>
> This moves all connection pinning state fully into the ConnStateData
> manager objects scope.
>
>
> Side changes that appear to be buggy code previously:
> * do not alter pinning state at the point where the pinned connection
> is about to start being used. Changes are only relevant at the point of
> pinning or unpinning.
>
> * unpin operation now closes the Server FD if still open. Previously
> there was the possibility that some code paths would leave server FD
> open and pconn it. (especially since the above mentioned state
> alteration cleared the "pinned" flag).

Applied to trunk. revno 11419

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.12
   Beta testers wanted for 3.2.0.7 and 3.1.12.1