Re: [PATCH] Reusable ACLChecklist

From: Tsantilas Christos <chtsanti_at_users.sourceforge.net>
Date: Mon, 13 Jun 2011 17:18:04 +0300

This patch fixes the ACLChecklist::fastCheck method so that it can
always be reusable.

On 06/10/2011 09:05 PM, Amos Jeffries wrote:

>
> Some fluffy bits:
> "The new methd does not change the internal state of the ACLChecklist
> object"
> * this is false. The funtion clearly changes currentAnswer().

This is true

>
> * the PROF_* bits used by fastCheck() need to be kept for benchmark
> profiling.

OK done.

>
> * can the local cbdata references be made CbcPointer please?
> That should clear up all the pointer shuffling.

It was not easy to use CbcPointers because of various
"error: invalid conversion from ‘const ...’ to ..." compile error
messages, which probably requires changes to CbcPointer code.
The problem here is that the ACLChecklist::accessList is const but the
CbcPointer does not support const cbdata classes.

>
> Amos

Received on Mon Jun 13 2011 - 14:18:26 MDT

This archive was generated by hypermail 2.2.0 : Tue Jun 14 2011 - 12:00:04 MDT