Re: [PATCH] Add DNS lookup step to ICAP connect

On 29/06/11 23:23, Tsantilas Christos wrote:
> My sense is that the commSetTimeout/comm_add_close_handler calls should
> moved from the Adaptation::Icap::Xaction::dnsLookupDone to the
> Adaptation::Icap::Xaction::noteCommConnected method.
>

Yes they should have been. Anything which depends on an open FD needs to
go in or after the ConnOpener callback handler.

THanks

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.12
   Beta testers wanted for 3.2.0.9 and 3.1.12.3