Re: [PATCH] have cf_gen.cc use iostreams instead of stdio

From: Kinkie <gkinkie_at_gmail.com>
Date: Mon, 8 Aug 2011 18:09:35 +0200

Fixed and committed.

Thanks.

On Mon, Aug 8, 2011 at 2:01 AM, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
> On Sun, 7 Aug 2011 23:02:20 +0200, Kinkie wrote:
>>
>> Hi all,
>>   a bit frustrated by MinGW not easily offering some non-ansi calls,
>> I've ported cf_gen.cc to use iostreams instead of C stdio.
>> As the topic is a more general than mswin, I'd like to commit to trunk
>> instead of the branch.
>> Build-tested.
>>
>> Thoughts?
>
>
> Fine by me. We need to do this as part of extracting config.h dependency
> from cf_gen anyways.
>
> There are a few trivial polishes needed before commit though:
>
>  * code formatting. Please ensure the tabs being added are all replaced with
> 4 spaces and things line up again afterwards.
>
>  * since you are moving the main() declaration for fp anyway please move it
> down to immediately before fp.open().
>
>
> Amos
>

-- 
    /kinkie
Received on Mon Aug 08 2011 - 16:09:42 MDT

This archive was generated by hypermail 2.2.0 : Tue Aug 09 2011 - 12:00:03 MDT