Re: [PATCH] Bug 3229: cf_gen.cc dependency removal / conversion to C++

On Tue, Aug 9, 2011 at 4:45 AM, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
>
> This converts the bulk of cf_gen to C++ OOP code.

Great! (even though my language of choice for converting cf_gen would
be perl, not c++, but it makes no sense to rewrite too deeply what is
working )

>  * char* tree members to std::string. Which eliminates xstrdup() and xis*()
> calls.
>
>  * structs to classes and replaces calloc/free with new/delete.
>
>  * link cf_gen_depends.cci directly to autoconf.h defines.
>
> The result of these is that we can erase the dependencies on util.h,
> time.cc, config.h, libcompat.la and libmisc.la. Directly fixing bug 3229 and
> other related cross-compile issues that keep appearing on various OS.

Great.

> I'm not sure if we can also drop dependencies on XTRA_LIBS and MING_LIBS.
> that would be nice. I've left them for now.

I expect this can be done. After this is in it'll be trivial to test
it on the build farm.

> There is a bit further cleanup we can do. Replacing several classes with
> std::list<std::string>.

Nod.

One point: on IRC Alex suggested we keep the #if HAVE_* guards around
includes to ensure maximum compatibility.

-- 
    /kinkie