Re: [PATCH] Bug 3229: cf_gen.cc dependency removal / conversion to C++

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Thu, 18 Aug 2011 01:31:19 +1200

On 09/08/11 14:45, Amos Jeffries wrote:
>
> This converts the bulk of cf_gen to C++ OOP code.
>
> * char* tree members to std::string. Which eliminates xstrdup() and
> xis*() calls.
>
> * structs to classes and replaces calloc/free with new/delete.
>
> * link cf_gen_depends.cci directly to autoconf.h defines.
>
> The result of these is that we can erase the dependencies on util.h,
> time.cc, config.h, libcompat.la and libmisc.la. Directly fixing bug 3229
> and other related cross-compile issues that keep appearing on various OS.
>
> I'm not sure if we can also drop dependencies on XTRA_LIBS and
> MING_LIBS. that would be nice. I've left them for now.
>
> There is a bit further cleanup we can do. Replacing several classes with
> std::list<std::string>.
>
>
> The final remaining cross-compiler bug is to generate cf_gen for the
> local build machine rather than the destination host environment.
>
> Amos

Applied to squid-3.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.14
   Beta testers wanted for 3.2.0.10
Received on Wed Aug 17 2011 - 13:31:26 MDT

This archive was generated by hypermail 2.2.0 : Wed Aug 17 2011 - 12:00:03 MDT