Re: [PATCH] Ignore and warn about attempts to reconfigure static Rock store options.

 On Tue, 20 Sep 2011 02:40:13 +0400, Dmitry Kurochkin wrote:
> Hi.
>
> Attached patch does some polishing for Rock store cache_dir
> reconfiguration.
>
>
> Some Rock store options cannot be changed dynamically: path, size,
> and
> max-size. Before the change, there were no checks during reconfigure
> to prevent changing these options. This may lead to Rock cache
> corruption and other bugs. The patch adds necessary checks to Rock
> store code. If user tries to change an option that cannot be updated
> dynamically, a warning is reported and the value is left unchanged.
>
> Regards,
> Dmitry

 Of itself the patch looks okay.

 BUT... IMO _path_ should never be re-configurable. That may impact the
 patch implementation.

 If rock store can't handle multiple cache_dir of type rock with unique
 paths there is something deeper wrong.

 AFAIK path should be the unique key to identify different cache_dir.
 Changing the path means a completely different dir is now being
 referenced. If not already loaded the dir needs to be loaded as if on
 startup. If any existing are no longer referenced the old cache_dir
 details needs discarding.

 Amos
Received on Tue Sep 20 2011 - 02:10:21 MDT