Re: [PATCH] HttpBody refactoring

From: Kinkie <gkinkie_at_gmail.com>
Date: Sun, 4 Dec 2011 14:13:34 +0100

> HttpBody::setMb():
> * please note that protect from assign-to-self is omitted due to
> non-existence of copy constructor.
>  If such a constructor is ever added the protection will be needed.

Done.

> HttpBody.h:
> * do you need to have the filename repeated and "Created On" section of
> copyright? we use AUTHOR: prefix instead to assign copyrights with the Squid
> blurb.

Standard Eclipse template blurb. Now removed.

> * packInto() docs:
>   s/output  operation/output operation/
>   s/note:/note/

Done

> * in the hasContent() docs
>   s/contents/content/
>   consider using \return instead of "check" in "check whether..."

Done

> * contentSize(), content() docs
>  use \return instead of just the word.

Done.

> +1 from me.

Ok, thanks.
Merging.

-- 
    /kinkie
Received on Sun Dec 04 2011 - 13:13:43 MST

This archive was generated by hypermail 2.2.0 : Mon Dec 05 2011 - 12:00:05 MST