Re: [PATCH] fix up external acl type dumping

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Sat, 16 Jun 2012 15:21:18 +1200

On 16/06/2012 7:41 a.m., Robert Collins wrote:
> On Sat, Jun 16, 2012 at 7:33 AM, Alex Rousskov
> <rousskov_at_measurement-factory.com> wrote:
>> IMHO, ##__VA_ARGS__ is not worth the trouble in this particular case.
>> However, even if you disagree, please use at least one argument (empty
>> string with a corresponding %s if needed to prevent compiler warnings?).
> The ## is meant to compensate for that, according to the reading I
> did. I'm happy to back it out if it causes jenkins failures, but would
> like to at least try it as-is.
>
> -Rob

You can upload it on any of the Jenkins jobs labeled ALPHA (login, click
Build and fill out the form) to see if it breaks when applied to trunk
on that OS/compiler.

Amos
Received on Sat Jun 16 2012 - 03:21:31 MDT

This archive was generated by hypermail 2.2.0 : Sat Jun 16 2012 - 12:00:09 MDT