Re: [PATCH] HTTP/1.1 response caching upgrade

On 10/16/2012 03:24 AM, Amos Jeffries wrote:
> Updated patch with requested changes.

> +#if USE_HTTP_VIOLATIONS // response header Pragma is undefined in HTTP
> + else {
> + // Expensive calculation. So only do it IF the CC: header is not present.
> +
> + /* HACK: Pragma: no-cache in _replies_ is not documented in HTTP,
> + * but servers like "Active Imaging Webcast/2.0" sure do use it */
> + if (rep->header.has(HDR_PRAGMA) &&
> + rep->header.hasListMember(HDR_PRAGMA,"no-cache",','))
> + EBIT_SET(entry->flags, ENTRY_REVALIDATE);
> + }
> +#endif

Pragma is defined in HTTP RFC 2616. Even if that definition is removed
in HTTPbis, it does not make our interpretation of Pragma a violation.
Using a header "undefined in HTTP" is not an HTTP violation.

The old Squid code did not have USE_HTTP_VIOLATIONS restriction around
Pragma handling. I do not see why this restriction should be introduced.
If it is introduced, please document both the fact and rationale in the
proposed commit message.

Thank you,

Alex.
Received on Wed Oct 17 2012 - 15:52:33 MDT