Re: [PATCH] StoreID stage 2\3 fully functional StoreID interface.

I worked on the old code and was reading introduction to c++ to
understand better things in the code and it really gave me a lot.
Now I got some problem while using concurrency with store_id helper.

If I use concurrency and even on "1" I get assertion problem in the
cache log as:
2012/12/13 01:26:56 kid2| assertion failed:
../../12500/src/HttpHeader.cc:1271: "name && value"
2012/12/13 01:26:56 kid1| assertion failed:
../../12500/src/HttpHeader.cc:1271: "name && value"

Which basically is this code:
http://bazaar.launchpad.net/~squid/squid/trunk/view/head:/src/HttpHeader.cc#L1289

For this specific branch I am using is 12500 so I will later update it.
Was there anything that fixed or could have fixed this kind of issue?

I Hope to release the newer PREVIEW\PATCH in the next couple days.

Thanks,
Eliezer

On 12/6/2012 2:09 PM, Amos Jeffries wrote:
> On 6/12/2012 9:03 p.m., Eliezer Croitoru wrote:
>> Thanks Alex and Amos,
>>
>> The Audit gave me a lot!
>> I hope to sit on it today and if not today later next week.
>> For now I am using this patch in a testing machine to make sure it
>> does what needed for a reasonable period of time without bad side
>> effects.
>>
>> How long it is before committing a patch to trunk?(after all the
>> fixes) it would need approval of the others and 10 more days?
>
> When you submit a patch which three separate people can agree (with a
> "+1" vote) that there are no changes to be made. Submitting counts as
> one vote from you. The time to commit once agreement is reached is
> usually minutes or hours - getting the agreement is the long part for
> those like yourself still learning the coding styles required.
>
> Amos
>

-- 
Eliezer Croitoru
https://www1.ngtech.co.il
sip:ngtech_at_sip2sip.info
IT consulting for Nonprofit organizations
eliezer <at> ngtech.co.il