Re: [PATCH] Resource leak in UFSSwapDir

From: Alex Rousskov <rousskov_at_measurement-factory.com>
Date: Fri, 21 Dec 2012 09:18:00 -0700

On 12/21/2012 03:51 AM, Kinkie wrote:
>> Please do not check for nil before deleting a pointer. Delete does that
>> for you.
>
> Hi all,
> revised patch, addressing this for the whole destructor.
> It passes build and unit tests.

Looks good to me, but I did not check whether there are some hidden
dependencies among the objects we are destroying that require us to set
their pointers to NULL and/or destroy them in a certain order. However,
I do not object to this being committed if nobody can check this.

Thank you,

Alex.
Received on Fri Dec 21 2012 - 16:18:13 MST

This archive was generated by hypermail 2.2.0 : Fri Dec 21 2012 - 12:00:20 MST