Re: [PATCH] Fix memory leaks in auth_digest.cc

On 22/12/2012 3:59 a.m., Kinkie wrote:
> Hi all,
> the attached patch addresses Coverity issue 740431: in
> Auth::Digest::Config::decode, username is allocated on the heap and
> not freed in case of certain errors.
>
> I've taken the chance to get rid of a few HEREs.
>
> An alternate approach would be to pass Strings (eventually, SBufs)
> around, so that the memory would be reclaimed automatically.
>
>
> --
> /kinkie

Looks okay to me.

The rfcnb patch snuck in the front there and needs removing from this
auth change, but otherwise fine.

Amos
Received on Thu Dec 27 2012 - 01:51:30 MST