Re: [PATCH] Floating point exception due to "divide by zero" (BUG #3736)

On 01/11/2013 01:57 AM, Tianyin Xu wrote:

> + if (Config.Store.objectsPerBucket == 0)
> + fatal("'store_objects_per_bucket' should be larger than 0.");
> +
> + if (Config.Store.avgObjectSize == 0)
> + fatal("'store_avg_object_size' should be larger than 0.");
> +

In each case, please either check for "<= 0" to keep the check in sync
with the message or, if we are actually using negative values, please
change the message to say "cannot be zero". I suspect the former is the
right approach here.

Thank you,

Alex.
Received on Sat Jan 12 2013 - 00:30:39 MST