[PATCH] StoreId with couple cosmetics in sync with trunk 1639

From: Eliezer Croitoru <eliezer_at_ngtech.co.il>
Date: Sun, 03 Feb 2013 10:13:31 +0200

Thanks Amos for the last audit.

Alex I am sorry but as for now I cannot unify the redirectStateData
objects into one method for both redirect and storeid helpers.
We can post a TODO list as a block and work it out in time.

I have couple things in mind that I will need you help about:
- making it possible for the helper to handle multiple StoreId results.
I was planing of adding some code that if there are couple options for
StoreId the helper code will look up for them in the cache and then will
decide which one of them to use.
How bad it sounds?
This function will allow metalink headers to be used in a case they exists.
- adding ICAP the option to respond with a StoreId for the request.(what
about the response? it's too late right? only 30x can be used after the
headers.)

I opened a bugzilla to follow up the feature.
http://bugs.squid-cache.org/show_bug.cgi?id=3758

If you know of some bug request or anything post here or the bugzilla.

This time I didn't compiled the patch yet.

at Client_side_request.cc clientStoreIdAccessCheckDone() :line 940
I'v added a debug section which I am not sure about how the "answer"
enum will behave.(should I expect a number to be printed?)

at thr url.cc urlCanonical() returns request->canonical
Amos pointed that there might be a NULL reply from that which is not clear.
I do not remember too much about it now but it's important for docs.

Thanks ALL,

Eliezer

Received on Sun Feb 03 2013 - 08:14:02 MST

This archive was generated by hypermail 2.2.0 : Wed Feb 06 2013 - 12:00:05 MST