Re: [PATCH] Refactor mime.cc

On 02/10/2013 10:02 AM, Kinkie wrote:

> the attached patch aims to c++-ify and standardize a bit more mime.cc
> and the auxiliary classes it contains.

> + MimeIcon(const char *aName);

Missing "explicit" keyword to prevent accidental conversions of
c-strings to MimeIcons.

> private:
> + MimeIcon();

> +private:
> + MimeEntry();

Both not needed: If you remove both declarations, it would still be
impossible to create MimeIcon or MimeEntry using a default constructor
because there will be no default constructor generated by the compiler
since you provide explicit [parameterized] constructors for both classes.

Thank you,

Alex.
Received on Wed Feb 13 2013 - 16:00:40 MST