Re: [PATCH] Optimization: domain agnostic pconn

On 19/11/2011 9:02 a.m., Henrik Nordström wrote:
> lör 2011-11-19 klockan 00:56 +1300 skrev Amos Jeffries:
>> This removes the domain from the server pconn key.
> I would not recommend doing this.
>
> We started out with only IP:PORT as the key, but then had to add doamin
> to origin server connections due to broken servers not expecting
> persistent connecitons crossing domain based virtual servers.
>
>> Squid using cache_peer can see a large number of wasted idle connections
>> to their peers due to the key domain value if the peer hostname is not
>> substituted properly. There is also a similar affect when contacting
>> servers with virtual hosted domains.
> domain should never be part of a cache_peer pconn key. Don't even see a
> need of using the peer name there.
>
> but what you describe above sounds like bugs where it somehow is
> forgotten that a connection was sent to a peer. Better fix those bugs
> than hiding their effect.
>
> Regards
> Henrik
>

Sorry for leaving this one so long. It turned out the forward.cc code
was being inconsistent with its use of peer hostname and name= when
pushing and popping.
I adjusted the patch to send NULL when peer is used but
request->GetHost() on all DIRECT traffic. It appears to work almost as
well as the first version.

Applied to trunk as rev.12699.

Amos
Received on Mon Feb 18 2013 - 13:13:21 MST