On 01/11/2013 05:39 PM, Alex Rousskov wrote:
> Hello,
>
> I think there is an off-by-one error in the external_acl.cc code
> that kills Squid:
>
>> 2013/01/11 15:13:18.037| external_acl.cc(843) aclMatchExternal: "http://example-3.com/req=debug,uniq4,abort_at=AfterReqHs/resp=debug/": queueing a call.
>> 2013/01/11 15:13:18.037| external_acl.cc(845) aclMatchExternal: "http://example-3.com/req=debug,uniq4,abort_at=AfterReqHs/resp=debug/": return -1.
>> 2013/01/11 15:13:18.037| Acl.cc(321) checklistMatches: ACL::ChecklistMatches: result for 'dummyfilter' is -1
>> 2013/01/11 15:13:18.037| Acl.cc(339) matches: ACLList::matches: result is false
>> 2013/01/11 15:13:18.037| Checklist.cc(275) matchNode: 0x99fe8a8 matched=0 async=1 finished=0
>> 2013/01/11 15:13:18.037| Checklist.cc(312) matchNode: 0x99fe8a8 going async
>> 2013/01/11 15:13:18.037| Acl.cc(61) FindByName: ACL::FindByName 'dummyfilter'
>> 2013/01/11 15:13:18.037| Checklist.cc(131) asyncInProgress: ACLChecklist::asyncInProgress: 0x99fe8a8 async set to 1
>> 2013/01/11 15:13:18.037| external_acl.cc(1407) Start: fg lookup in 'dummyfilter' for 'http://example-3.com/req=debug,uniq4,abort_at=AfterReqHs/resp=debug/'
>> 2013/01/11 15:13:18.037| external_acl.cc(1450) Start: 'dummyfilter' queue is too long
>> 2013/01/11 15:13:18.037| assertion failed: external_acl.cc:1451: "inBackground"
>
>
> The enqueue check for external ACL lookups is inconsistent with the
> final queue length check in ExternalACLLookup::Start(). The former
> allows adding to the already full (but not yet overflowing) queue while
> the latter rightfully(?) asserts that the queue should not overflow.
Amos,
We discussed future steps to remove the whole queuing mess, and it
looks like we were in agreement on what needs to be done there.
Meanwhile, any objections to committing this specific bug fixing patch?
Thank you,
Alex.
Received on Mon Feb 18 2013 - 19:39:06 MST
This archive was generated by hypermail 2.2.0 : Tue Feb 19 2013 - 12:00:06 MST