Re: [PATCH] Preserve bare backslashes in AF and TT

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Thu, 21 Feb 2013 15:26:48 +1300

On 21/02/2013 2:47 p.m., Alex Rousskov wrote:
> Hello,
>
> It looks like NTLM and possibly Negotiate authentication is broken
> in trunk because Squid eats the bare backslash that AF responses use to
> separate authentication domain and user names. With the backslash
> removed, the merged domainuser name never matches, of course.
>
> The attached patch fixes the problem in my tests. Is there a better way
> to do this?
>
>
> Thank you,
>
> Alex.

strwordtok() is a function of our own creation so it is probably best
long term to adjust its API to include a flag for skipping the
slashDecode behaviour instead of creating duplicate code.

Example patch attached. Re-formatting is avoided to show clearly the
small amount of change needed.

I like the extra documentation you added about statics and use cases.
Can you write something similar about strwordtok() ?

Amos

Received on Thu Feb 21 2013 - 02:26:56 MST

This archive was generated by hypermail 2.2.0 : Thu Feb 21 2013 - 12:00:06 MST