Re: [PATCH] ACL to control TPROXY spoofing

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Fri, 01 Mar 2013 12:30:05 +1300

On 1/03/2013 5:47 a.m., Steve Hill wrote:
> On 26.02.13 21:56, Amos Jeffries wrote:
>
>> I'm happy with the use-case too now. If the code adjusted to 3.HEAD
>> still looks good I think it could go in.
>
> I've attached a patch against 3.HEAD. I've tested it, although I
> would appreciate it if you could double check that I'm using
> HttpRequest::Pointer correctly in client_side.cc.
>
> As well as the spoof_client_ip ACL, this introduces a new request flag
> called interceptTproxy, which is set for all TPROXY requests. The
> spoofClientIp flag is now only set for TPROXY requests that we want to
> spoof.
>
> Many thanks.
>

+1. Looks correct to me.

Just some formatting tweaks. But that can be done on commit.

Amos
Received on Thu Feb 28 2013 - 23:30:17 MST

This archive was generated by hypermail 2.2.0 : Fri Mar 01 2013 - 12:00:07 MST