Re: StringNG SBuf fixes for rfind()

On 4/03/2013 6:45 p.m., Amos Jeffries wrote:
> Hi Kinkie, Alex,
>
> I have managed to get the SBuf::rfind() functions fully in-sync with
> std::string versions
> http://master.squid-cache.org/~amosjeffries/patches/SBuf_fixes_mk2.patch
>
> There is a rather strange problem with using memrchr(). If you pass it
> the accurate count of bytes to check it fails to match start/end of
> hay properly in sub-string cases.
> I have had to use endPos+1 and artificially manipulate the situations
> where endPos == length().
>
> Now to re-enable the find() tests and fix those...
>

Make that
http://master.squid-cache.org/~amosjeffries/patches/SBuf_fixes_mk3.patch
Which fixes the find() issues as well.

Amos
Received on Tue Mar 05 2013 - 00:12:30 MST