Re: [PATCH] !closing assertion on helper call comm_read during reconfigure

On 11/05/2013 12:11 p.m., Alex Rousskov wrote:
> Hello,
>
> While helper reading code does check for COMM_ERR_CLOSING, it is not
> sufficient because helperReturnBuffer() called by that reading code may
> notice the helper shutdown flag (set earlier by reconfigure) and start
> closing the connection underneath the reading code feet.
>
>
> HTH,
>
> Alex.

+1. Seems okay. I'm not in a good position to test it right now though.

Amos
Received on Sat May 11 2013 - 05:38:52 MDT