Re: [PATCH] Fix leaks and check for newer libraries in Kerberos related helpers

On 26/08/2013 3:17 a.m., Markus Moeller wrote:
> Hi
> please find a patch for squid 3.4 trunk for:
>
> peer_proxy_negotiate_auth.cc
> negotiate_auth/kerberos
> external_acl/kerberos_ldap_group
>
> Please ignore my previous patch.
>
> Thank you
> Markus

Hi Markus,

The xfree() function supplied with Squid performs if(X != NULL) check
for you. There is no need to wrap it.
We also supply a safe_free() function which leaves the pointer set to
NULL after free. Between these two you can simplify the patch a lot.

Amos
Received on Mon Aug 26 2013 - 09:21:54 MDT