Re: /bzr/squid3/trunk/ r13038: Fix signedness comparison in SBuf

On 10/07/2013 04:36 AM, Amos Jeffries wrote:
> ------------------------------------------------------------
> revno: 13038
> committer: Amos Jeffries <squid3_at_treenet.co.nz>
> branch nick: trunk
> timestamp: Mon 2013-10-07 04:36:47 -0600
> message:
> Fix signedness comparison in SBuf
> modified:
> src/SBuf.h
>

> === modified file 'src/SBuf.h'
> --- a/src/SBuf.h 2013-10-07 08:32:15 +0000
> +++ b/src/SBuf.h 2013-10-07 10:36:47 +0000
> @@ -417,7 +417,7 @@
> * \throw SBufTooBigException if the user tries to allocate too big a SBuf
> */
> void reserveSpace(size_type minSpace) {
> - Must(0 <= minSpace);
> + Must(minSpace < maxSize);
> Must(length() <= maxSize - minSpace);
> reserveCapacity(length()+minSpace);
> }

This one should be minSpace <= maxSize, I think.

Alex.
Received on Mon Oct 07 2013 - 14:51:34 MDT