Re: [PATCH] Coverity defect 1135443

On 9/01/2014 9:57 p.m., Kinkie wrote:
> Hi,
> Coverity detected a possible division by zero in
> src/format/Format.cc line 500, on a Token->divisor.
> The defect is a false positive as that value is correctly initialized,
> but it could be a chance to document as a class invariant that that
> value must not be zero, and initialize it to 1 in the default
> constructor.
> Attached patch does just that.
>
>
>

+1. Please apply.

Amos
Received on Thu Jan 09 2014 - 23:53:35 MST