Re: [PATCH] SBuf conversion of HttpRequestMethod

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Wed, 09 Apr 2014 02:36:38 +1200

On 9/04/2014 2:22 a.m., Kinkie wrote:
> yes.
> But IMO wordlist and strList must die (eventually).

Fully agreed. I'm just saying I want to keep this patch about
HttpRequestMethod and not re-writing large portions of other components.

Amos

>
> On Tue, Apr 8, 2014 at 4:17 PM, Amos Jeffries wrote:
>> On 8/04/2014 10:30 p.m., Kinkie wrote:
>>> Removing squis-dwv from cc, I am on mobile and the HTML encoding would get
>>> the message rejected anyway.
>>>
>>> You don't need to c_str for printf-alikes, there's the SBUFPH / SBUFPRINT
>>> macros which also keeps things const. Ugly but it works
>>>
>>
>> Thanks for the reminder. Using that I can get rid of a handful more of
>> the most critical ones.
>>
>> But there are still a few leftovers: ACL building a wordlist, Digest
>> auth, access logging, errorpage and libformat.
>>
>> While those could be converted as well they are all tied to unrelated
>> code and it would blowout quickly. So I would rather leave them as
>> separate conversion patches.
>>
>> Amos
>>
Received on Tue Apr 08 2014 - 14:36:43 MDT

This archive was generated by hypermail 2.2.0 : Tue Apr 08 2014 - 12:00:12 MDT