Re: [PATCH] SBuf c-string comparisons

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Sun, 20 Apr 2014 20:08:02 +1200

On 19/04/2014 9:04 a.m., Alex Rousskov wrote:
> On 04/18/2014 12:12 PM, Amos Jeffries wrote:
>
>> If you are okay with the new bits marked (EXHIBIT A) and (EXHIBIT B) I
>> think we are done. These have already been checked against all unit
>> tests and passed.
>
> Please repost the current code/patch. Since most bugs were in the
> dependencies between different code parts, I do not think it is a good
> idea to review isolated EXHIBITs. We already know that you have not
> decreased the code complexity, so I am not going to _like_ what I see,
> but that is not the acceptance criteria either.
>

Fair enough. Attached.

Amos

Received on Sun Apr 20 2014 - 08:08:15 MDT

This archive was generated by hypermail 2.2.0 : Mon Apr 21 2014 - 12:00:13 MDT