[PATCH 5/8] reconfiguration leaks: objects tied to http_port

From: Alex Rousskov <rousskov_at_measurement-factory.com>
Date: Thu, 24 Apr 2014 18:55:32 -0600

Do not leak [SSL] objects tied to http_port and https_port on reconfigure.

PortCfg objects were not destroyed at all (no delete call) and were
incorrectly stored (excessive cbdata locking). This change adds
destruction and removes excessive locking to allow the destructed
object to be freed. It also cleans up forgotten(?) clientca and crlfile
PortCfg members.

This change fixes a serious leak but also carries an elevated risk:
There is a lot of code throughout Squid that does not check the pointers
to the objects that are now properly destroyed. It is possible that some
of that code will crash some time after reconfigure. It is not possible
to ensure that this does not happen without rewriting/fixing the
offending code to use refcounting. Such a rewrite would be a relatively
large change outside this patch scope. We may decide that it is better
to leak than to take this additional risk.

Alex.

Received on Fri Apr 25 2014 - 00:55:52 MDT

This archive was generated by hypermail 2.2.0 : Fri Apr 25 2014 - 12:00:16 MDT