Re: [PATCH 3/8] reconfiguration leaks: TcpAcceptor job

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Fri, 25 Apr 2014 19:51:37 +1200

On 25/04/2014 12:48 p.m., Alex Rousskov wrote:
> Do not leak TcpAcceptor job on reconfiguration
> by monitoring and reacting to the listening socket closure.
>
> Every job that waits for Comm I/O must have a FD closure handler.
> Unfortunately, we currently cannot enforce that rule automatically.
>
> Alex.
>

The unused parameter 'io' on Comm::TcpAcceptor::handleClosure() should
be left without a name yes?

+1. Please apply ASAP. The above can be fixed on commit.

Amos
Received on Fri Apr 25 2014 - 07:51:43 MDT

This archive was generated by hypermail 2.2.0 : Fri Apr 25 2014 - 12:00:16 MDT