Re: [PATCH] rock fixes and improvements

On 27/04/2014 6:09 a.m., Alex Rousskov wrote:
> Hello,
>
> The attached patch contains several fixes and improvements of the
> shared memory and rock disk caching code, some of them quite important.
> Here is the summary (detailed change descriptions are quoted at the end
> of this message):
>

in DiskIO/IpcIo/IpcIoFile.cc:
 * please use SBuf for DbName global
 * please remove HERE in chunk at line 888:
  - debugs(79,3, HERE << "rock db opened " ...

in MemStore.cc:
 * consider making ExtrasLabel and SpaceLabel into SBuf. same in
Transients.cc

in Store.h:
 * new documentation for checkCacheable() is unclear. It only made sense
after reading the related functions descriptions and some code.
 - Consider "whether generally cacheable" as the brief and expanding the
brackets to separate sentences.
 - please consider making the function return bool for even better

 * please use "// TODO" (non-doxygen slashes) for private TODOs, or
proper doxygen "/// \todo" tag for ones that to be published in the code
manual TODO page.

in src/ipc/StoreMap.cc:
* Missing decrement?
@@ -64,7 +74,7 @@
- --shared->count;
+ anchors->count;

Amos
Received on Mon Apr 28 2014 - 15:11:37 MDT