Re: [PATCH] external_acl_type format cleanup pt 1

On 05/06/2014 08:37 AM, Amos Jeffries wrote:

> Several of the external ACL format codes have been added to
> Format::ByteCode_t without equivalent logformat TokenTableEntry's

> @ Format::Format::assemble(...)
> + // XXX: external_acl_type format codes are not yet output by this code
> + case LFT_EXT_ACL_USER_CERT_RAW:
> + case LFT_EXT_ACL_USER_CERTCHAIN_RAW:
> + case LFT_EXT_ACL_USER_CERT:
> + case LFT_EXT_ACL_USER_CA_CERT:
> + case LFT_EXT_ACL_CLIENT_EUI48:
> + case LFT_EXT_ACL_CLIENT_EUI64:
> + case LFT_EXT_ACL_NAME:
> + case LFT_EXT_ACL_DATA:

I am not versed enough in Format terminology to quickly grok the above,
so I have to ask: What does the above mean from the admin point of view?
Does the proposed change completely removes support for some external
ACL %macros? Or do we still support everything but require some %macro
renaming for the old squid.confs to continue to work?

If this patch requires admins to rename any %macros, please provide a
renaming table in release notes or at least in the proposed commit message.

If this patch removes any existing functionality (from the admin point
of view), please say so explicitly.

Thank you,

Alex.
Received on Tue May 06 2014 - 16:01:21 MDT