[PATCH] Fix for Squid 3.4.5 segfault

From: Steve Hill <steve_at_opendium.com>
Date: Mon, 12 May 2014 17:47:41 +0100

Squid 3.4.5 segfaults when formatting log lines for me. It looks like
this is down to fmt->data.timespec being uninitialised, and affects the
%tg format specifier.

As far as I can tell, fmt->data.timespec is never set anywhere, and we
should probably be using fmt->data.string instead.

The attached patch removes timespec, fixing the segmentation fault.

I can't see any relevant code change between 3.4.4 and 3.4.5, so I'm
guessing this may be down to the toolchain change. Presumably the
compiler used to initialise the pointer to NULL and nolonger does.

-- 
  - Steve Hill
    Technical Director
    Opendium Limited     http://www.opendium.com
Direct contacts:
    Instant messager: xmpp:steve_at_opendium.com
    Email:            steve_at_opendium.com
    Phone:            sip:steve_at_opendium.com
Sales / enquiries contacts:
    Email:            sales_at_opendium.com
    Phone:            +44-844-9791439 / sip:sales_at_opendium.com
Support contacts:
    Email:            support_at_opendium.com
    Phone:            +44-844-4844916 / sip:support_at_opendium.com

Received on Mon May 12 2014 - 16:47:49 MDT

This archive was generated by hypermail 2.2.0 : Mon May 12 2014 - 12:00:13 MDT