Re: [PATCH] compat/xstdint.h

On 3/06/2014 9:54 p.m., Kinkie wrote:
> Hi,
> this patch extracts the stdint compat to a compat/xstdint.h header,
> and references that from strtoll.c and Tokenizer.cc;
>
> Full farm tested, it introduces no regressions.
>

This is a C++11 portabability issue.

1) When C++11 is available this new header should prefer cstdint. eg.

 #if __cplusplus == 201103L
 #include <cstdint>
 #else

  ... the current header contents...
 #endif

2) This header should be included into compat/types.h or compat/compat.h
instead of via Tokenizer.cc / strtoll.c

3) please also check for other includes of stdint.h or cstdint around
the code to remove once (2) is done.

Amos
Received on Tue Jun 03 2014 - 10:58:24 MDT