Re: [PATCH] Better handling of huge native FTP requests

On 08/19/2014 04:05 AM, Amos Jeffries wrote:
> On 13/08/2014 11:46 a.m., Alex Rousskov wrote:
>> Hello,
>>
>> The attached patch avoids assertions on large FTP commands and
>> cleans up both general and FTP-specific error handling code during
>> request parsing. Please see the patch preamble for technical details.

> I've not had time for much detail checking. From a quick scan all I
> could see was that in Ftp::Server::parseOneRequest flags.readMore is set
> to false twice. The one at the method end can now be removed.
>
> +1. If this works for you I think it can go in.

Committed to trunk as r13535 after removing the extra flags.readMore
assignment.

Thank you,

Alex.
Received on Tue Aug 19 2014 - 18:13:13 MDT