Re: ssl bug? [patch]

Hankin wrote:

> when I run ./client https://www.paragon.co.uk/
>
> but it doesn't close the socket, when I visit...

This is a bug.
Patch attached.

---
Henrik Nordstom
Spare time Squid hacker

Index: squid/src/forward.c
diff -u squid/src/forward.c:1.1.1.5 squid/src/forward.c:1.1.1.5.6.1
--- squid/src/forward.c:1.1.1.5 Sat Oct 3 02:58:14 1998
+++ squid/src/forward.c Sun Oct 25 16:01:41 1998
@@ -255,7 +255,6 @@
     peer *p;
     request_t *request = fwdState->request;
     StoreEntry *entry = fwdState->entry;
- ErrorState *err;
     debug(17, 5) ("fwdDispatch: FD %d: Fetching '%s %s'\n",
         fwdState->client_fd,
         RequestMethodStr[request->method],
@@ -299,9 +298,8 @@
         default:
             debug(17, 1) ("fwdDispatch: Cannot retrieve '%s'\n",
                 storeUrl(entry));
- err = errorCon(ERR_UNSUP_REQ, HTTP_BAD_REQUEST);
- err->request = requestLink(request);
- errorAppendEntry(entry, err);
+ fwdFail(fwdState, ERR_UNSUP_REQ, HTTP_BAD_REQUEST, -1);
+ comm_close(fwdState->server_fd);
             break;
         }
     }
Received on Sun Oct 25 1998 - 08:00:33 MST