Re: assertion failed: comm.c:583: "F->flags.open"

From: Henrik Nordstrom <hno@dont-contact.us>
Date: Fri, 04 Jun 1999 22:47:15 +0000

Right. It is a bug in one of my FTP patches.

Thanks for your excellent report!

--
Henrik Nordstrom
Spare time Squid hacker
Apiset Tananchai wrote:
> After browse through the code, I think below patch should solve the
> problem since comm_close() already called inside ftpFailed()
> 
> --- src/ftp.c~  Fri Jun  4 18:45:45 1999
> +++ src/ftp.c   Fri Jun  4 18:45:52 1999
> @@ -337,7 +337,6 @@
>      StoreEntry *entry = ftpState->entry;
>      debug(9, 4) ("ftpTimeout: FD %d: '%s'\n", fd, storeUrl(entry));
>      ftpFailed(ftpState, ERR_READ_TIMEOUT);
> -    comm_close(ftpState->ctrl.fd);
>      /* don't modify ftpState here, it has been freed */
>  }
> 
> Suggestion?
> --
> aet
Received on Fri Jun 04 1999 - 16:39:08 MDT

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:46:44 MST