Re: Truncating the logged timestamp

Hmm.. what is the hurry? %d formats expand as required. The specified field width is only a
minimum width. Actually expanding it is likely to cause quite a bit of problems as it changes the
log format by introducing a leading space for dates prior to 1M.

If you want to change to %010d or remove the field width completely then I have no objection.

--
Henrik
Adrian Chadd wrote:
> Guys,
>
> This needs to be commmitted ASAP. I didn't realise that noone had
> noticed this over the last couple of weeks.
>
> If noone objects I'll commit this to 2.4 and HEAD tonight or
> tomorrow morning. I then think we should roll another release
> (oops! :)
>
> Adrian
>
> Index: src/access_log.c
> ===================================================================
> RCS file: /server/cvs-server/squid/squid/src/access_log.c,v
> retrieving revision 1.68
> diff -u -r1.68 access_log.c
> --- src/access_log.c    2001/04/10 17:01:35     1.68
> +++ src/access_log.c    2001/08/29 13:24:09
> @@ -242,7 +242,7 @@
>         client = inet_ntoa(al->cache.caddr);
>      user = accessLogFormatName(al->cache.authuser ?
>         al->cache.authuser : al->cache.rfc931);
> -    logfilePrintf(logfile, "%9d.%03d %6d %s %s/%03d %d %s %s %s %s%s/%s %s",
> +    logfilePrintf(logfile, "%10d.%03d %6d %s %s/%03d %d %s %s %s %s%s/%s %s",
>         (int) current_time.tv_sec,
>         (int) current_time.tv_usec / 1000,
>         al->cache.msec,
> Index: src/store_log.c
> ===================================================================
> RCS file: /server/cvs-server/squid/squid/src/store_log.c,v
> retrieving revision 1.22
> diff -u -r1.22 store_log.c
> --- src/store_log.c     2001/02/17 07:28:50     1.22
> +++ src/store_log.c     2001/08/29 13:24:09
> @@ -69,7 +69,7 @@
>          * Because if we print it before the swap file number, it'll break
>          * the existing log format.
>          */
> -       logfilePrintf(storelog, "%9d.%03d %-7s %02d %08X %s %4d %9d %9d %9d %s %d/%d %s %s\n",
> +       logfilePrintf(storelog, "%10d.%03d %-7s %02d %08X %s %4d %9d %9d %9d %s %d/%d %s %s\n",
>             (int) current_time.tv_sec,
>             (int) current_time.tv_usec / 1000,
>             storeLogTags[tag],
>
> ----- End forwarded message -----