MAGIC1 in src/fs/aufs/store_asyncufs.h

We have:

    #define NUMTHREADS (Config.cacheSwap.n_configured*16)
    #define MAGIC1 (NUMTHREADS*Config.cacheSwap.n_configured*5)

which means:

    #define MAGIC1 (Config.cacheSwap.n_configured*16*Config.cacheSwap.n_configured*5)

It seems wrong to me that MAGIC1 is proportional to the SQUARE of
the number of cache_dir's. I could even argue that it should be
logarithmic since performance doesn't really scale linearly with
#disks or cache_dirs.

Also I would suggest that these calculations use the number
of AUFS cache_dirs, which might be less than the total number.
Kind of hard to put that in a #define though.

Duane W.
Received on Mon Aug 04 2003 - 11:31:19 MDT