squid-3.0-PRE3-20031112 icp denied bug?

From: Gonzalo Arana <garana@dont-contact.us>
Date: 19 Nov 2003 18:47:35 -0300

Hi,

Brief version: squid 3 dies when an icp query is denied.

Long version:

If I configure squid 3.0-PRE3-20031112 with "icp_access deny all" (which
I think is the default), and receives an ICP query from a squid
2.5STABLE3, squid 3 dies with (debug_options ALL,9):

icpHandleUdp: FD 11: received 107 bytes from REMOTE-IP.
init-ing hdr: 0x84ca038 owner: 1
aclCheckFast: list: 0x82da8c0
ACLChecklist::preCheck: 0xbffff8f8 checking 'icp_access deny all'
ACLList::matches: checking all
aclMatchAcl: checking 'acl all src 0.0.0.0/0.0.0.0'
aclMatchIp: 'REMOTE-IP' found
aclmatchAclList: 0xbffff8f8 returning true (AND list satisfied)
ACLChecklist::markFinished: 0xbffff8f8 checklist processing finished
hdr->owner = 1
cleaning hdr: 0x84ca038 owner: 1
hdr->owner = 1
cleaning hdr: 0x84ca038 owner: 1
ACLChecklist::~ACLChecklist: destroyed 0xbffff8f8
icpDenyAccess: Access Denied for REMOTE-IP by all.
icpUdpSend: FD 11 sending ICP_DENIED, 103 bytes to REMOTE-IP:3130
assertion failed: HttpHeader.cc:374: "hdr->owner > hoNone && hdr->owner
<= hoReply"

hdr->owner is 0 (zero), so hdr->owner > hoNone is violated.

Is that assert ok? Should it be hdr->owner >= hoNone?

Thank you very much in advance,

-- 
Gonzalo Arana <garana@uolsinectis.com.ar>
UOL-Sinectis S.A.
Received on Wed Nov 19 2003 - 14:40:57 MST

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:20:47 MST