Re: Developer for IPv6 Squid patch.

From: Henrik Nordstrom <>
Date: Mon, 18 Apr 2005 23:52:49 +0200 (CEST)

On Mon, 18 Apr 2005, Rafael Martinez Torres wrote:

> Following rule 2, ("do never commmit anything directly in HEAD")

It's more than a rule. It's enforced, and if you somehow manage to bypass
the weak access controls then your changes will get automatically wiped

HEAD at sourceforge is not the main Squid tree, only a shadow of the main

> - This patch does change literally the term IN_ADDR by in_addr in all the
> files containing this term, except the file "inet_ntoa.c", the only one
> not including "config.h" (either direct or undirectly).


> - The correposding "defines" are in config.h . They are guarded by "INET6"
> define, (#ifdef INET6), so branches others that squid3-ipv6 should not be
> affected in their compilations.


> Questions:
> ---------
> -Thought the "config.h" as the best place to do defines. Any other
> suggestion ?

It's good.

> In a long term, if this change is to be discarded, it can easily
> rebuild by an script ( or the revesing patch)

It should only get discarded if the ipv6 porting comes up with a better
method, replacing it with something else.

Patch applied.

Received on Mon Apr 18 2005 - 15:52:51 MDT

This archive was generated by hypermail pre-2.1.9 : Sun May 01 2005 - 12:00:06 MDT