Re: cvs commit: squid3/src/ICAP ICAPConfig.cc MsgPipeData.h

From: Henrik Nordstrom <hno@dont-contact.us>
Date: Mon, 20 Feb 2006 00:24:16 +0100 (CET)

On Fri, 17 Feb 2006 wessels wrote:

> Removed static requestLink() and requestUnlink() methods. Replaced them
> with HTTPMSGLOCK() and HTTPMSGUNLOCK() macros.

Ugh.. why?

Any change introducing macros into C++ code is... in nearly all cases not
well thought over..

The correct solution is that HttpRequest (or perhaps HttpMsg) should be
refcounted I think.

Regards
Henrik
Received on Sun Feb 19 2006 - 16:24:20 MST

This archive was generated by hypermail pre-2.1.9 : Tue Feb 28 2006 - 12:00:05 MST