Re: Bug review request

Hi Henrik,

At 05.57 14/08/2006, Henrik Nordstrom wrote:

>sön 2006-08-13 klockan 22:37 +0200 skrev Guido Serassio:
> > Hi,
> >
> > I'm trying to close the Bug #212.
> > Someone could review the proposed patch ?
> >
> > It' should be incomplete, some errors still need to be verified.
>
>Looked at it and my gut feeling is that errorCon should be extended with
>a request_t argument, pulling all the common details of the request..

I agree, it's a definitive fix.

Should be something like this:

> ->request

err->request = requestLink(request);

But not always err->request is linked to a request, it could be a problem ?

> ->src_addr

Some confusion here, sometimes:

err->src_addr = conn->peer.sin_addr;
or err->src_addr = http->conn->peer.sin_addr;

some other times:

err->src_addr = request->client_addr;

What is correct ?

> ->auth_user_request

In client_side.c (clientAccessCheckDone()) there is:

         if (http->conn->auth_user_request)
             err->auth_user_request = http->conn->auth_user_request;
         else if (http->request->auth_user_request)
             err->auth_user_request = http->request->auth_user_request;

where http is a clientHttpRequest.

Not clear what should do here ....

Regards

Guido

-
========================================================
Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135 Fax. : +39.011.9781115
Email: guido.serassio@acmeconsulting.it
WWW: http://www.acmeconsulting.it/
Received on Mon Aug 14 2006 - 02:32:31 MDT