Re: COSS problem

Hi Adrian,

Il 03.44 23/09/2006 Adrian Chadd ha scritto:
> >
> > The attached patch adds a stripePath() function similar to the 3.0 one.
> > When the coss cache_dir argument is a directory, the "/stripe" suffix
> > is automatically added.
>
>Looks good!

OK, I will commit.

Another thing:

In storeCossDirSwapLogFile(), if Config.Log.swap is given, things are
always OK, but if Config.Log.swap is not configured and sd->path is
not a directory, aka is a regular file or a device, things are very
wrong: we append "/swap.state" to sd->path ....

I think that here we must also add a check if sd->path is a
directory, and squid should fatal() if a device or file is specified
without configuring cache_swap_log in squid.conf.

Regards

Guido

-
========================================================
Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135 Fax. : +39.011.9781115
Email: guido.serassio@acmeconsulting.it
WWW: http://www.acmeconsulting.it/
Received on Sat Sep 23 2006 - 03:15:19 MDT