Re: squid3-ipv6 squid3/include util.h,1.10.8.6,1.10.8.7

sön 2007-01-07 klockan 03:46 +0000 skrev Amos Jeffries:
>
> + #if INET6
> + #include <arpa/inet.h>
> + #endif
> +

Isn't the above an contradiction?

>
> typedef struct IN_ADDR SIA;
> + /* FIXME INET6 warning(error): 'struct in_addr' declared inside parameter list */
> SQUIDCEXTERN int safe_inet_addr(const char *, struct in_addr *);
> #ifdef INET6

in_addr should be IN_ADDR everywhere I think. From what I could tell the
ipv6 branch switches to using exclusively IPv6 addresses everywhere,
which is fine considering that IPv4 is included in the IPv6 address
space.

Also the sizeof magic you added in rfc1035.c can not work.. It's always
an in6_addr, but might contain an IPv4 address in IPv6 format..

A more significant problem is in the A lookup. It currently only does
AAAA lookup in IPv6 more, should try both AAAA and A if I am not
mistaken.

Regards
Henrik